Skip to content

Add in-spec hyperlinks to make it more navigable #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2014

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Oct 7, 2014

Slight improvement of hypelinks in the spec rules, since we have anchors, let's use them.

This is not urgent at all and probably should be done after @viktorklang's update the the rules in that PR: #117

Changes:

  • Adds in–spec links between "see x.xx" elements
  • Links to footnotes
  • 4.1 (processor rules) was referencing to [1] but there's no 1 footnote for this section...? Removed the reference.

@ktoso ktoso force-pushed the spec-more-links-ktoso branch from 698b749 to f2129f1 Compare October 7, 2014 11:04
@viktorklang
Copy link
Contributor

Looks awesome, great idea.

@jbrisbin
Copy link

👍

@viktorklang
Copy link
Contributor

@reactive-streams/contributors Ample time has been given to comment, please give a 👍 or object to this change before the 24th of October GMT+0. If no one objects before that then this will be merged.

@viktorklang
Copy link
Contributor

@ktoso Could you verify that this is up to date with current master?

@viktorklang viktorklang modified the milestone: 1.0.0-RC1 Oct 24, 2014
@ktoso
Copy link
Contributor Author

ktoso commented Oct 24, 2014

Definitely, I'll rebase soon (I'm on a conference) :-)

@viktorklang
Copy link
Contributor

@ktoso What kind of an excuse is that? ;-)

@ktoso ktoso force-pushed the spec-more-links-ktoso branch from f2129f1 to c66aa6b Compare October 25, 2014 00:01
@ktoso
Copy link
Contributor Author

ktoso commented Oct 25, 2014

Maybe a bit wrongly worded, I meant I wouldn't have internet for a while as conf just ended and walking around. ;-)

Rebased and matches latest README, the rules touched in this PR (or referenced by it) were not influenced by latest pull requests.

@viktorklang
Copy link
Contributor

@ktoso I was joking :)

viktorklang added a commit that referenced this pull request Oct 25, 2014
Add in-spec hyperlinks to make it more navigable
@viktorklang viktorklang merged commit 290bd92 into reactive-streams:master Oct 25, 2014
@viktorklang
Copy link
Contributor

@reactive-streams/contributors Merging :)

@ktoso
Copy link
Contributor Author

ktoso commented Oct 25, 2014

:-) no worries, thanks for merging! Looking forward to having a 1.0 RC soon :-)

@ktoso ktoso deleted the spec-more-links-ktoso branch October 27, 2014 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants